SERDHA/serdha-0-api.kt
1
0
Fork 1
Code Issues 4 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Unsafe returnColumn in 'SELECT' queries #1

New Issue
Closed
opened 2025-02-24 11:07:06 +00:00 by xomrk · 1 comment
xomrk commented 2025-02-24 11:07:06 +00:00
Owner
Copy Link

src/commonMain/kotlin/ru/landgrafhomyak/db/serdha0/api/queries/SelectQuery.kt Line 78 in be1ac99550
public fun <RT, DT : DatabaseType<RT>> returnColumn(name: String, column: IntermediateColumn<RT, DT, qUE>): Column<RT, DT, qUE>

This function not applicable to UNION because it has it's own return:

src/commonMain/kotlin/ru/landgrafhomyak/db/serdha0/api/queries/SelectQuery.kt Line 256 in be1ac99550
public fun <RT, DT : DatabaseType<RT>> uniteColumns(first: Column<RT, DT, fqUE>, last: Column<RT, DT, lqUE>): IntermediateColumn<RT, DT, qUE>

Also there is potential errors in returns from queries with reducers.

https://git.landgrafhomyak.ru/SERDHA/serdha-0-api.kt/src/commit/be1ac99550d7c26fe4385ccae817e65cab054fc1/src/commonMain/kotlin/ru/landgrafhomyak/db/serdha0/api/queries/SelectQuery.kt#L78 This function not applicable to `UNION` because it has it's own return: https://git.landgrafhomyak.ru/SERDHA/serdha-0-api.kt/src/commit/be1ac99550d7c26fe4385ccae817e65cab054fc1/src/commonMain/kotlin/ru/landgrafhomyak/db/serdha0/api/queries/SelectQuery.kt#L256 Also there is potential errors in returns from queries with reducers.
xomrk added the
Compile-time safety
 label 2025-02-24 11:11:38 +00:00
xomrk added this to the (deleted) project 2025-02-24 11:15:20 +00:00
xomrk added the
Not a error
 label 2025-02-24 11:22:29 +00:00
xomrk closed this issue 2025-02-24 11:22:44 +00:00
xomrk commented 2025-02-24 11:27:55 +00:00
Author
Owner
Copy Link

src/commonMain/kotlin/ru/landgrafhomyak/db/serdha0/api/queries/SelectQuery.kt Line 256 in be1ac99550
public fun <RT, DT : DatabaseType<RT>> uniteColumns(first: Column<RT, DT, fqUE>, last: Column<RT, DT, lqUE>): IntermediateColumn<RT, DT, qUE>

This function returns IntermediateColumn that can be use for next computations inside this query, not returns. Since it's single producer of IntermediateColumn this API is safe.

https://git.landgrafhomyak.ru/SERDHA/serdha-0-api.kt/src/commit/be1ac99550d7c26fe4385ccae817e65cab054fc1/src/commonMain/kotlin/ru/landgrafhomyak/db/serdha0/api/queries/SelectQuery.kt#L256 This function returns `IntermediateColumn` that can be use for next computations inside this query, not returns. Since it's single producer of `IntermediateColumn` this API is safe.
Sign in to join this conversation.
v0.0
Branches Tags
Labels
Clear labels   
Compile-time safety

   
Enhancement proposal

   
Missed functionality

   
Next generation

   
Not a error

   
Typo/naming

   
Undefined behaviour
No Label
Compile-time safety
Enhancement proposal
Missed functionality
Next generation
Not a error
Typo/naming
Undefined behaviour
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SERDHA/serdha-0-api.kt#1
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?